Add available devices and dtypes selection to runner.py #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+56
to
+57
| parser.add_argument('--dtype', '--dtypes', type=str, default="float32 float64", nargs='+', | ||
| choices=("float32", "float64"), |
There was a problem hiding this comment.
Out of PR scope, but int32 might be added
There was a problem hiding this comment.
It is better to add this kind of changes in other PR
Alexsandruss
requested changes
Dec 23, 2021
Comment on lines
+109
to
+110
| logging.info('The device parameter value is not defined in config, ' | ||
| 'none is used') |
There was a problem hiding this comment.
Move up from if because --device might be added later for xgboost, for example.
There was a problem hiding this comment.
For now other configs do not support device parameter and such message may be confusing
Alexsandruss
approved these changes
Dec 24, 2021
Pahandrovich
approved these changes
Dec 24, 2021
KalyanovD
approved these changes
Dec 24, 2021
samir-nasibli
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters to runner.py that define devices and data types available to run
Unselected devices and data types will be ignored in configs
for example if config contains
device: ["host", "gpu", "cpu"]and you run
python runner.py --devices cpu gpucpu and gpu cases will be launched,
but if config contains:
device: ["host", "gpu"]and you run
python runner.py --devices cpu gpuonly gpu case will be launched
default values do not limit the available devices and data types